Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Mercurial (HG) support #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added Mercurial (HG) support #9

wants to merge 5 commits into from

Conversation

clarenceb
Copy link

Thanks for creating this plugin. Its very useful. Where I am currently working we use Mercurial repositories and I saw your plugin doesn't support it yet. I made some changes to it and it now works with Mercurial. Feel free to accept the changes if you are happy with them.

Things to note:

  • I couldn't figure out how to initialise a HG repo like "git init --bare" . It seems I had to commit a file for the repo to be valid for the tests (hg locate would fail otherwise). Let me know if you know a better way!
  • Due to the behaviour above, in a couple of tests I have to specifically check if we are testing against a HG repository and then remove the special dummy file so the tests can pass.

@buildhive
Copy link

Jenkins » scm-sync-configuration-plugin #26 SUCCESS
This pull request looks good
(what's this?)

@fcamblor
Copy link
Member

Sounds great ! :-)

Will take a little time during christmas to review this. Thanks.

@LionelOnTech
Copy link

Fantastic! Always needed this to work with Mercurial as well. Thanks! Hope it gets incorporated soon.

@dbatwa
Copy link

dbatwa commented May 28, 2013

This is very useful. When is it getting pulled?

@fcamblor
Copy link
Member

An issue already exists and is blocked by a wider problematic

I know this is not hard to click the "merge pull request" button, but we must think about long term support

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@danehammer
Copy link

Given this has been sitting here for 2 years, I don't agree with the notion that a very good idea for refactoring can block this being pulled in, because for the last 2 years this work has been left sitting here.

I would be willing to get this back up to snuff with master, but is it going to remain blocked by JENKINS-18124?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@clarenceb @buildhive @fcamblor @LionelOnTech @dbatwa @jenkinsadmin @danehammer